From ca23be0a161593548158fb04780fbe07b5293a62 Mon Sep 17 00:00:00 2001 From: Julien Chaffraix Date: Sun, 26 Sep 2010 16:17:01 -0700 Subject: [PATCH 1/7] security.c: Fix ftp_send_command. My use of va_args was completely wrong. Fixed the usage so that we send the right commands! --- lib/security.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/security.c b/lib/security.c index 693be3f..5708078 100644 --- a/lib/security.c +++ b/lib/security.c @@ -128,9 +128,13 @@ static int ftp_send_command(struct connectdata *conn, const char *message, ...) int ftp_code; ssize_t nread; va_list args; + char print_buffer[50]; va_start(args, message); - if(Curl_ftpsendf(conn, message, args) != CURLE_OK) { + vsnprintf(print_buffer, sizeof(print_buffer), message, args); + va_end(args); + + if(Curl_ftpsendf(conn, print_buffer) != CURLE_OK) { ftp_code = -1; } else { @@ -139,7 +143,6 @@ static int ftp_send_command(struct connectdata *conn, const char *message, ...) } (void)nread; /* Unused */ - va_end(args); return ftp_code; } -- 1.7.0.4