From 8b4fffbe98b4d6b860d81114cb41012ea582b05f Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 4 Mar 2013 15:20:22 +0100 Subject: [PATCH] AddFormData: prevent only directories from being posted Commit f4cc54cb4746ae5a6d (shipped as part of the 7.29.0 release) was a bug fix that introduced a regression in that while trying to avoid allowing directory names, it also forbade "special" files like character devices and more. like "/dev/null" as was used by Oliver who reported this regression. Reported by: Oliver Bug: http://curl.haxx.se/mail/archive-2013-02/0040.html --- lib/formdata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/formdata.c b/lib/formdata.c index 308b33a..49c5d29 100644 --- a/lib/formdata.c +++ b/lib/formdata.c @@ -831,7 +831,7 @@ static CURLcode AddFormData(struct FormData **formp, file */ if(!strequal("-", newform->line)) { struct_stat file; - if(!stat(newform->line, &file) && S_ISREG(file.st_mode)) + if(!stat(newform->line, &file) && !S_ISDIR(file.st_mode)) *size += file.st_size; else return CURLE_BAD_FUNCTION_ARGUMENT; -- 1.7.10.4